Skip to content

[PLT-1587] Added remaining flake rules #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Oct 30, 2024

Description

  • Added in remaining ruff rules besides bare exception which would be a huge change
  • Vast majority of changes are just removing unused variables and duplicate imports

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner October 30, 2024 03:00
@@ -367,23 +366,6 @@ def video_ontology(client: Client):
return ontology


@pytest.fixture
def polygon_inference(prediction_id_mapping):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate fixture

@@ -49,18 +49,6 @@ def get_text(name, text_content):
return ClassificationAnnotation(name=name, value=Text(answer=text_content))


def get_checklist(name, answer_names):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate function

@@ -65,13 +65,6 @@ def test_dataset_filtering(client, dataset_for_filtering):
assert list(client.get_datasets(where=Dataset.name == name_2)) == [d2]


def test_dataset_filtering(client, dataset_for_filtering):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant